+2
Fixed

External links broken

musicEnfanthen 3 years ago updated 3 years ago 8

The links to external pdfs, papers, doi's et al. are broken (maybe since the last update concerning the svg icons).


Probably, there is a wrong "log_download"-function for the onClick-Handler:


"a href="LINK" onclick="log_download(BIBBASELINK) ..."


When changing it in the console to "show_link" manually, links work fine again. Is this "log_download" by intention or only a left-over from debugging?

It`s weird, on another device everything works as expected. So I guess this is just an issue with my settings and can be closed/deleted. Sorry for the inconvenience.

Sorry for reopening this. But after a colleague on the other half of the planet encountered the same issue (compare https://github.com/music-encoding/music-encoding.github.io/issues/20), I think this is more general as thought before.


After some digging, it turned out that any browser's activated "Do not track" option/plugin will prevent BibBase's external links (that have the click handler "log_download" mentioned above) from doing anything.


Maybe another reported issue is connected to this: https://bibbase.userecho.com/communities/1/topics/242-safari-prevent-cross-site-tracking-option

So what can we do for now? Do you see any chance for a fix? Turning off "Do not track" settings, just to open a PDF or clicking on a DOI link, should not be necessary and can not be a satisfactory solution because it is difficult to communicate to users and any user would think the links just don't work or the site is broken.

Thanks for investigating this further and reopening the issue! I agree. This is a bug that needs to be addressed. We'll try to fix it as soon as possible.


Thanks a lot, looking forward to a fix. Let us know if we can be of any further help with this issue.

+1
Fixed

Stefan: Thanks again for reporting and debugging this issue. That was a big help! It is fixed now.

Thank you for the fix! Works perfectly now.